emilia
/
plate-tool
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Callback refactoring #2

New Issue
Closed
opened 2024-01-13 02:25:03 +00:00 by emilia · 3 comments
emilia commented 2024-01-13 02:25:03 +00:00
Owner
Copy Link

this issue is just for tracking all of the rancid callbacks and de-rancidifying them

  • main_window.rs
    • toggle_in_transfer_hashes
    • new_plate_dialog
    • open_new_plate_dialog
    • new_button
    • export_csv_button
    • export_json_button
    • import_json_button
      • input_callback
    • import_transfer_csv_callback
      • input_callback
        • onload
          • submit_callback

that's... enough for now. this is disgusting.

this issue is just for tracking all of the rancid callbacks and de-rancidifying them - [x] `main_window.rs` - [x] `toggle_in_transfer_hashes` - [x] `new_plate_dialog` - [x] `open_new_plate_dialog` - [x] `new_button` - [x] `export_csv_button` - [x] `export_json_button` - [x] `import_json_button` - [x] `input_callback` - [x] `import_transfer_csv_callback` - [x] `input_callback` - [x] `onload` - [x] `submit_callback` that's... enough for now. this is disgusting.
emilia self-assigned this 2024-01-13 02:25:21 +00:00
emilia added the
de-rancidification
 label 2024-01-13 02:26:53 +00:00
emilia referenced this issue from a commit 2024-01-13 18:57:47 +00:00
Import json button refactor
emilia commented 2024-01-13 18:59:30 +00:00
Author
Owner
Copy Link

main_window complete, moving to new_plate_dialog.rs:

  • new_plate_callback
  • onclose

main_window was the worst offender, these should take less time to resolve.

main_window complete, moving to `new_plate_dialog.rs`: - [x] `new_plate_callback` - [x] `onclose` `main_window` was the worst offender, these should take less time to resolve.
emilia referenced this issue from a commit 2024-01-13 19:05:48 +00:00
new_plate_dialog callbacks
emilia commented 2024-01-13 19:09:04 +00:00
Author
Owner
Copy Link

Moving to transfer_menu.rs, which has a good number of callbacks:

  • on_name_change
  • on_src_region_change
  • on_dest_region_change
  • on_source_interleave_x_change
  • on_source_interleave_y_change
  • on_dest_interleave_x_change
  • on_dest_interleave_y_change
  • on_volume_change
  • new_transfer_button_callback
  • save_transfer_button_callback
  • delete_transfer_button_callback
Moving to `transfer_menu.rs`, which has a good number of callbacks: - [x] `on_name_change` - [x] `on_src_region_change` - [x] `on_dest_region_change` - [x] `on_source_interleave_x_change` - [x] `on_source_interleave_y_change` - [x] `on_dest_interleave_x_change` - [x] `on_dest_interleave_y_change` - [x] `on_volume_change` - [x] `new_transfer_button_callback` - [x] `save_transfer_button_callback` - [x] `delete_transfer_button_callback`
emilia referenced this issue from a commit 2024-02-10 21:38:26 +00:00
Add callbacks per #2
emilia commented 2024-02-10 21:53:07 +00:00
Author
Owner
Copy Link

Resolved by 020f7740d3

Resolved by 020f7740d3
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
beta-release
feature/eframe
dev
main
callback-refactor
v0.2.0
v0.1.0-rc1
Labels
Clear labels   
bug

Something is not working

  
de-rancidification

rewriting trash

  
enhancement

New feature

No Label
bug
de-rancidification
enhancement
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
emilia
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: emilia/plate-tool#2
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?